-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix native gesture reattach #3672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that android got a bit "out of sync" with iOS, can we make it so that one is analogous to another?
packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm
Outdated
Show resolved
Hide resolved
packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm
Outdated
Show resolved
Hide resolved
...ler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt
Outdated
Show resolved
Hide resolved
if (!self.subviews[0]) | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, but this should never happen with NativeHandler
and if it does, I believe we would like to throw an error instead of silent fail.
Description
In
NativeDetector
native gesture failed to reattach when child changed.Test plan
Add a logging message in attach/detach in
android/.../react/RNGestureHandlerRegistry.kt
andapple/RNGestureHandlerRegistry.m
`